From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] fix up thinko in jbd2 revoke code
Date: Thu, 3 Apr 2008 12:17:27 -0400
Message-ID: <20080403161727.GA627@infradead.org>
References: <1206979062.3192.26.camel@localhost.localdomain> <1206988258.3653.2.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-fsdevel@vger.kernel.org, Duane Griffin <duaneg@dghda.com>
To: Mingming Cao <cmm@us.ibm.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:40686 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756451AbYDCQRa (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 3 Apr 2008 12:17:30 -0400
Content-Disposition: inline
In-Reply-To: <1206988258.3653.2.camel@localhost.localdomain>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Mar 31, 2008 at 11:30:58AM -0700, Mingming Cao wrote:
> On Mon, 2008-03-31 at 10:57 -0500, James Bottomley wrote:
> > This commit:
> > 
> > commit e898f3154d78d1520265aade0992981866d827fb
> > Author: Duane Griffin <duaneg@dghda.com>
> > Date:   Tue Mar 25 19:47:39 2008 -0400
> > 
> >     jbd2: tidy up revoke cache initialisation and destruction
> > 
> > Introduced a thinko (it doesn't check whether jbd2_revoke_record cache
> > is null, it checks jbd2_revoke_table_cache twice).
> > 
> > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> > 
> Signed-off-by: Mingming Cao <cmm@us.ibm.com>
> 
> Thanks, I picked this up in ext4 patch queue.

anyone care to convert this function to proper goto-based error
unwinding?