From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Allison Subject: Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation Date: Thu, 3 Apr 2008 15:34:27 -0700 Message-ID: <20080403223427.GA20019@samba1> References: <20080402062508.017738664@chook.melbourne.sgi.com> <20080402062709.011126702@chook.melbourne.sgi.com> <20080403171450.GB22385@infradead.org> <20080403172400.GC22812@samba1> <20080403184333.GA30595@infradead.org> <20080403184739.GB6100@samba1> <20080403185526.GA6045@infradead.org> <20080403185717.GB6045@infradead.org> Reply-To: Jeremy Allison Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeremy Allison , Barry Naujok , xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mail.samba.org ([66.70.73.150]:46730 "EHLO lists.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757581AbYDCWe3 (ORCPT ); Thu, 3 Apr 2008 18:34:29 -0400 Content-Disposition: inline In-Reply-To: <20080403185717.GB6045@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Apr 03, 2008 at 02:57:17PM -0400, Christoph Hellwig wrote: > On Thu, Apr 03, 2008 at 02:55:26PM -0400, Christoph Hellwig wrote: > > On Thu, Apr 03, 2008 at 11:47:39AM -0700, Jeremy Allison wrote: > > > > CI filenames can work perfectly fine without adding validation of file > > > > names by treating non-conformant bytestreams as not having lower/upper > > > > case variants. > > > > > > Sorry, then I'm not understanding your objection to this patch (and I > > > don't think I understood that sentence :-). > > > > I objected to the part of the patch I've quoted (and the bitsrelated to > > it), not all of it. That how we do reviews in kernel land, not sure > > how samba handles it if you have a binary object/don't object policy.. > > oops, look like the quote actually got deleted accidentally. sorry > I'ltake that comment back. > > The part I object to are the various calls to xfs_unicode_validate > in the namespace operations. Ah, ok - now I understand - thanks ! We also have a finer-grained objection system than entire patch btw. Jeremy.