From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [patch 1/15] Makefiles and Kconfig Date: Tue, 8 Apr 2008 10:33:17 +0200 Message-ID: <20080408083316.GA31262@logfs.org> References: <20080401181308.512473173@logfs.org> <20080401181332.853833001@logfs.org> <200804080230.17426.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org To: Arnd Bergmann Return-path: Received: from lazybastard.de ([212.112.238.170]:55637 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752091AbYDHId2 (ORCPT ); Tue, 8 Apr 2008 04:33:28 -0400 Content-Disposition: inline In-Reply-To: <200804080230.17426.arnd@arndb.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 8 April 2008 02:30:16 +0200, Arnd Bergmann wrote: > On Tuesday 01 April 2008, joern@logfs.org wrote: > > --- linux-2.6.24logfs/fs/Kconfig~logfs 2008-03-24 12:39:10.19093934= 2 +0100 > > +++ linux-2.6.24logfs/fs/Kconfig 2008-04-01 19:48:18.517351063 +020= 0 > > @@ -1385,6 +1385,23 @@ config JFFS2_CMODE_FAVOURLZO > > =20 > > endchoice > > =20 > > +config LOGFS > > + bool "Log Filesystem (EXPERIMENTAL)" >=20 > Is it really still the "Log Filesystem"? By now, I had the impression > that "logfs" is a name by itself, so it should be called the > "Logfs file system", and "config LOGFS_FS" respectively, like > JFFS2_FS, REISERFS_FS, AUTOFS_FS, UDF_FS etc. "Logfs file system" might make sense. LOGFS_FS is something I would rather avoid. For some reason my brain reacts strongly to repetition, redundancy and superfluous information. > You shouldn't add the Makefile and Kconfig before adding the actual > files, or you could cause git-bisect problems. :) I keep hearing that and I also continue to forget it. It shouldn't matter either way, because it simply makes no sense to merge 15 seperat= e patches file-by-file for something that is functionally one change. Th= e split is all about review and has nothing to do with merging. But if I finally remembered it, at least these comments would cease. I'll try. J=C3=B6rn --=20 Beware of bugs in the above code; I have only proved it correct, but not tried it. -- Donald Knuth -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html