From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Salomon Subject: Re: [patch 2/15] fs/logfs/logfs_abi.h Date: Tue, 8 Apr 2008 17:52:59 -0400 Message-ID: <20080408175259.6f5d3d2c@ephemeral> References: <20080401181308.512473173@logfs.org> <20080401181332.853833002@logfs.org> <200804080224.18014.arnd@arndb.de> <20080408093946.GA31266@logfs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org To: linux-kernel@vger.kernel.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 8 Apr 2008 11:39:46 +0200 J=C3=B6rn Engel wrote: > On Tue, 8 April 2008 02:24:17 +0200, Arnd Bergmann wrote: > >=20 > > Great to see a new version finally posted again! >=20 > As Artem already noted, the transition to write-back caching was a > significant change and initially caused a huge drop in quality. Took= a > while. >=20 > > On Tuesday 01 April 2008, joern@logfs.org wrote: > > > --- /dev/null 2008-04-02 16:29:12.813336657 +0200 > > > +++ linux-2.6.24logfs/fs/logfs/logfs_abi.h 2008-04-01 21:02:34.98= 0239877 +0200 > > > @@ -0,0 +1,523 @@ > > > +/* > > > + * fs/logfs/logfs.h > >=20 > > The comment doesn't match the file name, and the file name doesn't > > match the purpose -- you are not defining an "application" binary > > interface but rather the medium format, with the small exception > > of the chattr flags. >=20 > Now it matches the file name. If you have a better name than "abi", > I'll use that. >=20 > > > +#ifndef fs_logfs_logfs_abi_h > > > +#define fs_logfs_logfs_abi_h > >=20 > > Everyone else uses capital letters for these. >=20 > Changed. >=20 Hm, logfs.patch.771 contains lowercase. Do you have your latest patch set somewhere online? Alternatively, would you mind pushing your git tree somewhere public?