From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/7] omfs: add inode routines
Date: Sun, 13 Apr 2008 04:05:54 -0400
Message-ID: <20080413080554.GC9622@infradead.org>
References: <1208041121-26787-3-git-send-email-me@bobcopeland.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org
To: Bob Copeland <me@bobcopeland.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:58147 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751444AbYDMIFz (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 13 Apr 2008 04:05:55 -0400
Content-Disposition: inline
In-Reply-To: <1208041121-26787-3-git-send-email-me@bobcopeland.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Looks good.  Minor nitpick:

> +static void omfs_put_super(struct super_block *sb)
> +{
> +	struct omfs_sb_info *sbi = OMFS_SB(sb);
> +	if (sbi) {

This if check is no needed, as your fill_super method never returns
success without setting it up.