From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org, Bob Copeland <me@bobcopeland.com>
Subject: Re: [PATCH 3/7] omfs: add directory routines
Date: Sun, 13 Apr 2008 10:11:44 +0100 [thread overview]
Message-ID: <20080413101144.4d496e9d@core> (raw)
In-Reply-To: <1208041121-26787-4-git-send-email-me@bobcopeland.com>
> +static int omfs_readdir(struct file *filp, void *dirent, filldir_t filldir)
> +{
> + struct inode *dir = filp->f_dentry->d_inode;
> + struct buffer_head *bh = NULL;
> + if (filp->f_pos >> 32)
> + goto success;
f_pos may be 32bit in which case >> 32 does not have defined behaviour in
C.
Alan
next prev parent reply other threads:[~2008-04-13 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 22:58 [PATCH 3/7] omfs: add directory routines Bob Copeland
2008-04-13 8:07 ` Christoph Hellwig
2008-04-13 9:11 ` Alan Cox [this message]
2008-04-13 9:20 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2008-03-27 0:45 Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080413101144.4d496e9d@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).