From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org, Bob Copeland <me@bobcopeland.com>
Subject: Re: [PATCH 2/7] omfs: add inode routines
Date: Sun, 13 Apr 2008 10:17:43 +0100 [thread overview]
Message-ID: <20080413101743.7d762e58@core> (raw)
In-Reply-To: <1208041121-26787-3-git-send-email-me@bobcopeland.com>
> + * so we have to walk the tree. Both inodes and file data are allocated
> + * from the same map. This array can be big (300k) so we allocate
> + * in units of the blocksize.
sbi->s_num_blocks doesn't appear to be validated at the time of mount ?
> +static int omfs_fill_super(struct super_block *sb, void *data, int silent)
> +{
> + sbi->s_num_blocks = be64_to_cpu(omfs_sb->s_num_blocks);
> + sbi->s_blocksize = be32_to_cpu(omfs_sb->s_blocksize);
> + sbi->s_mirrors = be32_to_cpu(omfs_sb->s_mirrors);
> + sbi->s_root_ino = be64_to_cpu(omfs_sb->s_root_block);
> + sbi->s_sys_blocksize = be32_to_cpu(omfs_sb->s_sys_blocksize);
Several of these look like they should be checked before use elsewhere in
the code (eg blocksize is fed into shifts later)
next prev parent reply other threads:[~2008-04-13 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 22:58 [PATCH 2/7] omfs: add inode routines Bob Copeland
2008-04-13 8:05 ` Christoph Hellwig
2008-04-13 9:17 ` Alan Cox [this message]
2008-04-15 18:03 ` Miklos Szeredi
2008-04-15 18:33 ` Bob Copeland
2008-04-15 18:30 ` Marcin Slusarz
2008-04-15 23:56 ` Bob Copeland
2008-04-16 18:31 ` Marcin Slusarz
-- strict thread matches above, loose matches on Subject: below --
2008-03-27 0:45 Bob Copeland
2008-03-27 6:13 ` Andi Kleen
2008-03-27 12:38 ` Bob Copeland
2008-03-28 3:42 ` Arnd Bergmann
2008-03-28 13:34 ` Bob Copeland
2008-03-28 20:20 ` Pavel Machek
2008-03-30 3:21 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080413101743.7d762e58@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).