From: Bob Copeland <me@bobcopeland.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 2/7] omfs: add inode routines
Date: Tue, 15 Apr 2008 19:56:59 -0400 [thread overview]
Message-ID: <20080415235659.GA7068@hash.localnet> (raw)
In-Reply-To: <20080415183054.GA7176@joi>
On Tue, Apr 15, 2008 at 08:30:59PM +0200, Marcin Slusarz wrote:
> > + if (be32_to_cpu(omfs_sb->s_magic) != OMFS_MAGIC) {
>
> can be omfs_sb->s_magic != cpu_to_be32(OMFS_MAGIC)
> (cpu_to_be32 can be optimized away even on LE)
Good point, I'll change that.
> > + if (bh)
> > + brelse(bh);
> brelse(NULL) is safe to call
Yup, I saw that too. I dropped these and added the labels per Miklos'
suggestion.
> > + return ret;
> > +}
>
> this code leaks omfs_sbi_info (sbi)
This one I'm not seeing. FS core calls put_super if ret is nonzero so
this should be ok?
Thanks!
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2008-04-15 23:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 22:58 [PATCH 2/7] omfs: add inode routines Bob Copeland
2008-04-13 8:05 ` Christoph Hellwig
2008-04-13 9:17 ` Alan Cox
2008-04-15 18:03 ` Miklos Szeredi
2008-04-15 18:33 ` Bob Copeland
2008-04-15 18:30 ` Marcin Slusarz
2008-04-15 23:56 ` Bob Copeland [this message]
2008-04-16 18:31 ` Marcin Slusarz
-- strict thread matches above, loose matches on Subject: below --
2008-03-27 0:45 Bob Copeland
2008-03-27 6:13 ` Andi Kleen
2008-03-27 12:38 ` Bob Copeland
2008-03-28 3:42 ` Arnd Bergmann
2008-03-28 13:34 ` Bob Copeland
2008-03-28 20:20 ` Pavel Machek
2008-03-30 3:21 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415235659.GA7068@hash.localnet \
--to=me@bobcopeland.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).