From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: Re: [PATCH 2/7] omfs: add inode routines
Date: Wed, 16 Apr 2008 20:31:42 +0200
Message-ID: <20080416183114.GA6264@joi>
References: <1208041121-26787-3-git-send-email-me@bobcopeland.com> <20080415183054.GA7176@joi> <20080415235659.GA7068@hash.localnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org
To: Bob Copeland <me@bobcopeland.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from fg-out-1718.google.com ([72.14.220.152]:7828 "EHLO
	fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750974AbYDPScQ (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 16 Apr 2008 14:32:16 -0400
Received: by fg-out-1718.google.com with SMTP id l27so2518010fgb.17
        for <linux-fsdevel@vger.kernel.org>; Wed, 16 Apr 2008 11:32:13 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20080415235659.GA7068@hash.localnet>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Apr 15, 2008 at 07:56:59PM -0400, Bob Copeland wrote:
> > > +	return ret;
> > > +}
> > 
> > this code leaks omfs_sbi_info (sbi)
> 
> This one I'm not seeing.  FS core calls put_super if ret is nonzero so
> this should be ok?

Yep, you are right. Sorry for the noise.
I was mislead by other filesystems code.

Marcin