From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: Re: [PATCH 3/8] omfs: add inode routines
Date: Sun, 20 Apr 2008 11:57:22 +0200
Message-ID: <20080420095718.GA6079@joi>
References: <1208637457-24969-4-git-send-email-me@bobcopeland.com> <20080419212842.GA7888@joi>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: akpm@linux-foundation.org, hch@infradead.org,
	alan@lxorguk.ukuu.org.uk, miklos@szeredi.hu,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
To: Bob Copeland <me@bobcopeland.com>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1756211AbYDTJ7J@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20080419212842.GA7888@joi>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Sat, Apr 19, 2008 at 11:28:42PM +0200, Marcin Slusarz wrote:
> > +static void set_block_shift(struct omfs_sb_info *sbi)
> > +{
> > +	unsigned int scale = sbi->s_blocksize / sbi->s_sys_blocksize;
> > +	sbi->s_block_shift = 0;
> > +	for (scale >>= 1; scale; scale >>= 1)
> > +		sbi->s_block_shift++;
> > +}
> isn't it get_bitmask_order(scale - 1)?

I mean get_bitmask_order(scale >> 1) ;)

Marcin