From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/4] XFS: Name operation vector for hash and compare
Date: Mon, 21 Apr 2008 04:42:33 -0400
Message-ID: <20080421084233.GA10323@infradead.org>
References: <20080421083103.433280025@chook.melbourne.sgi.com> <20080421083644.158168432@chook.melbourne.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
To: Barry Naujok <bnaujok@sgi.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:42094 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753483AbYDUIme (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 21 Apr 2008 04:42:34 -0400
Content-Disposition: inline
In-Reply-To: <20080421083644.158168432@chook.melbourne.sgi.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

>  /*
> + * Search comparison results
> + */
> +typedef enum {
> +	XFS_CMP_DIFFERENT,	/* names are completely different */
> +	XFS_CMP_EXACT,		/* names are exactly the same */
> +	XFS_CMP_CASE		/* names are same but differ in case */
> +} xfs_dacmp_t;

Please don't add a typedef for this one, just use the enum type
directly.

Except for this this patch looks good to me.