* [2.6 patch] unexport get_empty_filp
@ 2008-04-21 8:47 Adrian Bunk
2008-04-21 8:52 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-04-21 8:47 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel
This patch removes the no longer used export of get_empty_filp.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
dbe53f5338ef9710ecfa92adffa42af6ba48c40c diff --git a/fs/file_table.c b/fs/file_table.c
index 986ff4e..bded3ce 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -141,8 +141,6 @@ fail:
return NULL;
}
-EXPORT_SYMBOL(get_empty_filp);
-
/**
* alloc_file - allocate and initialize a 'struct file'
* @mnt: the vfsmount on which the file will reside
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] unexport get_empty_filp
2008-04-21 8:47 [2.6 patch] unexport get_empty_filp Adrian Bunk
@ 2008-04-21 8:52 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2008-04-21 8:52 UTC (permalink / raw)
To: Adrian Bunk; +Cc: viro, linux-fsdevel
On Mon, Apr 21, 2008 at 11:47:54AM +0300, Adrian Bunk wrote:
> This patch removes the no longer used export of get_empty_filp.
Patch is good, but missing the actual rationale for it. The reason is
that we now have a slightly higher level alloc_file helper that properly
initialized the file struct and should be used instead.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-21 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-21 8:47 [2.6 patch] unexport get_empty_filp Adrian Bunk
2008-04-21 8:52 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).