From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [2.6 patch] unexport get_empty_filp
Date: Mon, 21 Apr 2008 04:52:40 -0400
Message-ID: <20080421085240.GA17709@infradead.org>
References: <20080421084754.GJ26897@cs181133002.pp.htv.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
To: Adrian Bunk <bunk@kernel.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:47195 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759624AbYDUIwn (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 21 Apr 2008 04:52:43 -0400
Content-Disposition: inline
In-Reply-To: <20080421084754.GJ26897@cs181133002.pp.htv.fi>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Apr 21, 2008 at 11:47:54AM +0300, Adrian Bunk wrote:
> This patch removes the no longer used export of get_empty_filp.

Patch is good, but missing the actual rationale for it.  The reason is
that we now have a slightly higher level alloc_file helper that properly
initialized the file struct and should be used instead.