* [2.6 patch] unexport get_fs_type
@ 2008-04-21 8:47 Adrian Bunk
2008-04-21 8:54 ` Christoph Hellwig
2008-04-21 9:07 ` Al Viro
0 siblings, 2 replies; 4+ messages in thread
From: Adrian Bunk @ 2008-04-21 8:47 UTC (permalink / raw)
To: Christoph Hellwig, viro; +Cc: linux-fsdevel
This patch removes the no longer used export of get_fs_type.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
d6e66d4515a7791cd5f51e889452603f26b006c6 diff --git a/fs/filesystems.c b/fs/filesystems.c
index f37f872..322363e 100644
--- a/fs/filesystems.c
+++ b/fs/filesystems.c
@@ -239,5 +239,3 @@ struct file_system_type *get_fs_type(const char *name)
}
return fs;
}
-
-EXPORT_SYMBOL(get_fs_type);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [2.6 patch] unexport get_fs_type
2008-04-21 8:47 [2.6 patch] unexport get_fs_type Adrian Bunk
@ 2008-04-21 8:54 ` Christoph Hellwig
2008-04-21 9:12 ` Al Viro
2008-04-21 9:07 ` Al Viro
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2008-04-21 8:54 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Christoph Hellwig, viro, linux-fsdevel
On Mon, Apr 21, 2008 at 11:47:58AM +0300, Adrian Bunk wrote:
> This patch removes the no longer used export of get_fs_type.
Again, patch is good but missing an explanation. get_fs_type grabs a
reference to the file_system_type which needs to be dropped using
put_filesystem which is not exported, so it can't be used from modules
without introducing a bug. Nor should it because it's an operation
that's only useful during mount VFS-level code. The only really valid
user is fs/super.c
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] unexport get_fs_type
2008-04-21 8:47 [2.6 patch] unexport get_fs_type Adrian Bunk
2008-04-21 8:54 ` Christoph Hellwig
@ 2008-04-21 9:07 ` Al Viro
1 sibling, 0 replies; 4+ messages in thread
From: Al Viro @ 2008-04-21 9:07 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Christoph Hellwig, linux-fsdevel
On Mon, Apr 21, 2008 at 11:47:58AM +0300, Adrian Bunk wrote:
> This patch removes the no longer used export of get_fs_type.
NAK; show me a replacement API for the same.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] unexport get_fs_type
2008-04-21 8:54 ` Christoph Hellwig
@ 2008-04-21 9:12 ` Al Viro
0 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2008-04-21 9:12 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Adrian Bunk, Christoph Hellwig, linux-fsdevel
On Mon, Apr 21, 2008 at 04:54:28AM -0400, Christoph Hellwig wrote:
> On Mon, Apr 21, 2008 at 11:47:58AM +0300, Adrian Bunk wrote:
> > This patch removes the no longer used export of get_fs_type.
>
> Again, patch is good but missing an explanation. get_fs_type grabs a
> reference to the file_system_type which needs to be dropped using
> put_filesystem which is not exported, so it can't be used from modules
> without introducing a bug. Nor should it because it's an operation
> that's only useful during mount VFS-level code. The only really valid
> user is fs/super.c
Bzzert. put_filesystem() will need to be reexported, I'm afraid...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-21 9:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-21 8:47 [2.6 patch] unexport get_fs_type Adrian Bunk
2008-04-21 8:54 ` Christoph Hellwig
2008-04-21 9:12 ` Al Viro
2008-04-21 9:07 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).