From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [2.6 patch] unexport get_fs_type Date: Mon, 21 Apr 2008 04:54:28 -0400 Message-ID: <20080421085428.GB17709@infradead.org> References: <20080421084758.GK26897@cs181133002.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Adrian Bunk Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:60671 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759884AbYDUIyc (ORCPT ); Mon, 21 Apr 2008 04:54:32 -0400 Content-Disposition: inline In-Reply-To: <20080421084758.GK26897@cs181133002.pp.htv.fi> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Apr 21, 2008 at 11:47:58AM +0300, Adrian Bunk wrote: > This patch removes the no longer used export of get_fs_type. Again, patch is good but missing an explanation. get_fs_type grabs a reference to the file_system_type which needs to be dropped using put_filesystem which is not exported, so it can't be used from modules without introducing a bug. Nor should it because it's an operation that's only useful during mount VFS-level code. The only really valid user is fs/super.c