From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 3/4] XFS: ASCII case-insensitive support
Date: Mon, 21 Apr 2008 05:03:20 -0400
Message-ID: <20080421090320.GA19639@infradead.org>
References: <20080421083103.433280025@chook.melbourne.sgi.com> <20080421083645.247895324@chook.melbourne.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
To: Barry Naujok <bnaujok@sgi.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:34894 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754437AbYDUJDU (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 21 Apr 2008 05:03:20 -0400
Content-Disposition: inline
In-Reply-To: <20080421083645.247895324@chook.melbourne.sgi.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> +extern struct dentry_operations xfs_ci_dentry_operations;

this one is not used nor does the variable exist.  Just kill it :)

> +static inline int xfs_sb_version_hasoldci(xfs_sb_t *sbp)
> +{
> +	return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_4) && \
> +		((sbp)->sb_versionnum & XFS_SB_VERSION_BORGBIT);
> +}

Lots of superflous braces here.  Should be:

static inline int xfs_sb_version_hasoldci(xfs_sb_t *sbp)
{
	return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_4) &&
		(sbp->sb_versionnum & XFS_SB_VERSION_BORGBIT);
}

(and yes, the other xfs_sb_version_ helpers need fixups like that
aswell)