From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Adrian Bunk <bunk@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: [2.6 patch] unexport get_fs_type
Date: Mon, 21 Apr 2008 10:12:23 +0100 [thread overview]
Message-ID: <20080421091223.GQ27459@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080421085428.GB17709@infradead.org>
On Mon, Apr 21, 2008 at 04:54:28AM -0400, Christoph Hellwig wrote:
> On Mon, Apr 21, 2008 at 11:47:58AM +0300, Adrian Bunk wrote:
> > This patch removes the no longer used export of get_fs_type.
>
> Again, patch is good but missing an explanation. get_fs_type grabs a
> reference to the file_system_type which needs to be dropped using
> put_filesystem which is not exported, so it can't be used from modules
> without introducing a bug. Nor should it because it's an operation
> that's only useful during mount VFS-level code. The only really valid
> user is fs/super.c
Bzzert. put_filesystem() will need to be reexported, I'm afraid...
next prev parent reply other threads:[~2008-04-21 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 8:47 [2.6 patch] unexport get_fs_type Adrian Bunk
2008-04-21 8:54 ` Christoph Hellwig
2008-04-21 9:12 ` Al Viro [this message]
2008-04-21 9:07 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421091223.GQ27459@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bunk@kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).