From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [2.6 patch] unexport get_fs_type
Date: Mon, 21 Apr 2008 10:12:23 +0100
Message-ID: <20080421091223.GQ27459@ZenIV.linux.org.uk>
References: <20080421084758.GK26897@cs181133002.pp.htv.fi> <20080421085428.GB17709@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Adrian Bunk <bunk@kernel.org>, Christoph Hellwig <hch@lst.de>,
	linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:42228 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754546AbYDUJM1 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 21 Apr 2008 05:12:27 -0400
Content-Disposition: inline
In-Reply-To: <20080421085428.GB17709@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Apr 21, 2008 at 04:54:28AM -0400, Christoph Hellwig wrote:
> On Mon, Apr 21, 2008 at 11:47:58AM +0300, Adrian Bunk wrote:
> > This patch removes the no longer used export of get_fs_type.
> 
> Again, patch is good but missing an explanation.  get_fs_type grabs a
> reference to the file_system_type which needs to be dropped using
> put_filesystem which is not exported, so it can't be used from modules
> without introducing a bug.  Nor should it because it's an operation
> that's only useful during mount VFS-level code.  The only really valid
> user is fs/super.c

Bzzert.  put_filesystem() will need to be reexported, I'm afraid...