From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/4] XFS: Unicode case-insensitive lookup implementation
Date: Mon, 21 Apr 2008 05:15:20 -0400 [thread overview]
Message-ID: <20080421091520.GA31070@infradead.org> (raw)
In-Reply-To: <20080421083645.799556386@chook.melbourne.sgi.com>
The patch looks quite clean, but there still is the fundamental issue
of rejecting perfectly fine UNIX filenames in xfs_unicode_validate,
as discussed in the last round a Unix filename is any valid
NULL-terminated bytestream with only ".", "..", and "/" special-cased
and this patch breaks this assumptions.
In addition to that I think xfs_unicode.[ch] should be split into
a small xfs-specific part for reading the on-disk case-folding table
and implementing the actual nameops, and the generic code for case
folding and compares and case-folded strings should be moved into lib/
as it's quite generic.
prev parent reply other threads:[~2008-04-21 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 8:31 [PATCH 0/4] XFS: case-insensitive lookup and Unicode support Barry Naujok
2008-04-21 8:31 ` [PATCH 1/4] XFS: Name operation vector for hash and compare Barry Naujok
2008-04-21 8:42 ` Christoph Hellwig
2008-04-21 8:31 ` [PATCH 2/4] XFS: Return case-insensitive match for dentry cache Barry Naujok
2008-04-21 8:59 ` Christoph Hellwig
2008-04-21 9:46 ` Christoph Hellwig
2008-04-22 3:54 ` Barry Naujok
2008-04-22 4:52 ` Christoph Hellwig
2008-04-21 21:13 ` David Chinner
2008-04-22 4:53 ` Christoph Hellwig
2008-04-22 2:07 ` Barry Naujok
2008-04-22 4:55 ` Christoph Hellwig
2008-04-21 8:31 ` [PATCH 3/4] XFS: ASCII case-insensitive support Barry Naujok
2008-04-21 9:03 ` Christoph Hellwig
2008-04-21 8:31 ` [PATCH 4/4] XFS: Unicode case-insensitive lookup implementation Barry Naujok
2008-04-21 9:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421091520.GA31070@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).