linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Check the mtd device in do_emergency_remount()
@ 2008-04-21 16:27 Michael Trimarchi
  2008-04-21 17:48 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Trimarchi @ 2008-04-21 16:27 UTC (permalink / raw)
  To: viro; +Cc: linux-fsdevel, linux-kernel, Michael Trimarchi

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

Allow superblocks managed by the mtd layer to be remounted.




      Inviato da Yahoo! Mail. 
La casella di posta intelligente.
http://it.docs.yahoo.com/mail/overview/index.html

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: check-mtd-device-emergency-remount.patch --]
[-- Type: text/x-patch; name="check-mtd-device-emergency-remount.patch", Size: 721 bytes --]

[PATCH] Check the mtd device in do_emergency_remount().

Allow superblocks managed by the mtd layer to be remounted.

Signed-off-by: Michael Trimarchi <michael@evidence.eu.com>

---
 fs/super.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/super.c b/fs/super.c
index 09008db..2f8f924 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -627,7 +627,8 @@ static void do_emergency_remount(unsigned long foo)
 		sb->s_count++;
 		spin_unlock(&sb_lock);
 		down_read(&sb->s_umount);
-		if (sb->s_root && sb->s_bdev && !(sb->s_flags & MS_RDONLY)) {
+		if (sb->s_root && (sb->s_bdev || sb->s_mtd)
+		   && !(sb->s_flags & MS_RDONLY)) {
 			/*
 			 * ->remount_fs needs lock_kernel().
 			 *
-- 
1.5.3.6


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Check the mtd device in do_emergency_remount()
  2008-04-21 16:27 [PATCH] Check the mtd device in do_emergency_remount() Michael Trimarchi
@ 2008-04-21 17:48 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2008-04-21 17:48 UTC (permalink / raw)
  To: Michael Trimarchi; +Cc: viro, linux-fsdevel, linux-kernel, Michael Trimarchi

On Mon, Apr 21, 2008 at 04:27:05PM +0000, Michael Trimarchi wrote:
> Allow superblocks managed by the mtd layer to be remounted.

Please just rip out do_emergency_remount entirely.  It's the equivalent
to and attempted full-filesystem revoke and just can't work.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-21 17:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-21 16:27 [PATCH] Check the mtd device in do_emergency_remount() Michael Trimarchi
2008-04-21 17:48 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).