From: Bob Copeland <me@bobcopeland.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, hch@infradead.org,
alan@lxorguk.ukuu.org.uk, marcin.slusarz@gmail.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/8] omfs: add file routines
Date: Mon, 21 Apr 2008 21:53:42 -0400 [thread overview]
Message-ID: <20080422015342.GA9591@hash.localnet> (raw)
In-Reply-To: <E1JnxxA-0002z2-NY@pomaz-ex.szeredi.hu>
On Mon, Apr 21, 2008 at 05:29:12PM +0200, Miklos Szeredi wrote:
> This instead?
>
> if (offset > 0) {
> ret = 0;
> map_bh(bh_result, inode->i_sb, offset);
> if (remain > max_blocks)
> remain = max_blocks;
> bh_result->b_size = (remain << inode->i_blkbits);
> goto out_brelse;
> }
Much cleaner, thanks!
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2008-04-22 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 20:37 [PATCH 5/8] omfs: add file routines Bob Copeland
2008-04-21 15:29 ` Miklos Szeredi
2008-04-22 1:53 ` Bob Copeland [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-26 21:26 Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422015342.GA9591@hash.localnet \
--to=me@bobcopeland.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).