From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Copeland Subject: Re: [PATCH 5/8] omfs: add file routines Date: Mon, 21 Apr 2008 21:53:42 -0400 Message-ID: <20080422015342.GA9591@hash.localnet> References: <1208637457-24969-6-git-send-email-me@bobcopeland.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, hch@infradead.org, alan@lxorguk.ukuu.org.uk, marcin.slusarz@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from mail.deathmatch.net ([70.167.247.36]:49951 "EHLO mail.deathmatch.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753500AbYDVBy7 (ORCPT ); Mon, 21 Apr 2008 21:54:59 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Apr 21, 2008 at 05:29:12PM +0200, Miklos Szeredi wrote: > This instead? > > if (offset > 0) { > ret = 0; > map_bh(bh_result, inode->i_sb, offset); > if (remain > max_blocks) > remain = max_blocks; > bh_result->b_size = (remain << inode->i_blkbits); > goto out_brelse; > } Much cleaner, thanks! -- Bob Copeland %% www.bobcopeland.com