From: Bob Copeland <me@bobcopeland.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, hch@infradead.org,
alan@lxorguk.ukuu.org.uk, marcin.slusarz@gmail.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/8] omfs: add inode routines
Date: Mon, 21 Apr 2008 22:11:03 -0400 [thread overview]
Message-ID: <20080422021103.GA9730@hash.localnet> (raw)
In-Reply-To: <E1Jnxhm-0002we-Tx@pomaz-ex.szeredi.hu>
On Mon, Apr 21, 2008 at 05:13:18PM +0200, Miklos Szeredi wrote:
> > + if (sbi->s_num_blocks != be64_to_cpu(omfs_rb->r_num_blocks)) {
> > + printk(KERN_ERR "omfs: block count discrepancy between "
> > + "super and root blocks (%llx, %llx)\n",
> > + sbi->s_num_blocks, be64_to_cpu(omfs_rb->r_num_blocks));
> > + goto out_bh;
>
> Jump to wrong label.
>
> Also label names are a bit chaotic. But that's a matter of taste...
Thanks, fixed and I changed the label names to e.g. out_brelse_bh2.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2008-04-22 2:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 20:37 [PATCH 3/8] omfs: add inode routines Bob Copeland
2008-04-19 21:28 ` Marcin Slusarz
2008-04-20 9:57 ` Marcin Slusarz
2008-04-21 0:41 ` Bob Copeland
2008-04-21 15:13 ` Miklos Szeredi
2008-04-22 2:11 ` Bob Copeland [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-26 21:26 Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422021103.GA9730@hash.localnet \
--to=me@bobcopeland.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).