From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Copeland Subject: Re: [PATCH 3/8] omfs: add inode routines Date: Mon, 21 Apr 2008 22:11:03 -0400 Message-ID: <20080422021103.GA9730@hash.localnet> References: <1208637457-24969-4-git-send-email-me@bobcopeland.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, hch@infradead.org, alan@lxorguk.ukuu.org.uk, marcin.slusarz@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from mail.deathmatch.net ([70.167.247.36]:59999 "EHLO mail.deathmatch.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756330AbYDVCLa (ORCPT ); Mon, 21 Apr 2008 22:11:30 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Apr 21, 2008 at 05:13:18PM +0200, Miklos Szeredi wrote: > > + if (sbi->s_num_blocks != be64_to_cpu(omfs_rb->r_num_blocks)) { > > + printk(KERN_ERR "omfs: block count discrepancy between " > > + "super and root blocks (%llx, %llx)\n", > > + sbi->s_num_blocks, be64_to_cpu(omfs_rb->r_num_blocks)); > > + goto out_bh; > > Jump to wrong label. > > Also label names are a bit chaotic. But that's a matter of taste... Thanks, fixed and I changed the label names to e.g. out_brelse_bh2. -- Bob Copeland %% www.bobcopeland.com