linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] XFS: Return case-insensitive match for dentry cache
Date: Tue, 22 Apr 2008 00:55:26 -0400	[thread overview]
Message-ID: <20080422045526.GC11321@infradead.org> (raw)
In-Reply-To: <op.t9zphzsa3jf8g2@pc-bnaujok.melbourne.sgi.com>

On Tue, Apr 22, 2008 at 12:07:01PM +1000, Barry Naujok wrote:
>> What about just using kmalloc here?  We know the length of the name
>> anyway, so there is no point of allocating the maximum possible size.
>
> Not with the CI/NLS, the length could be different.

Well, even then we know the length to allocate because it needs to
be passed up in the nls_name.  For the utf8 case the allocated space
for the string might just be different from the number of characters.


  reply	other threads:[~2008-04-22  4:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21  8:31 [PATCH 0/4] XFS: case-insensitive lookup and Unicode support Barry Naujok
2008-04-21  8:31 ` [PATCH 1/4] XFS: Name operation vector for hash and compare Barry Naujok
2008-04-21  8:42   ` Christoph Hellwig
2008-04-21  8:31 ` [PATCH 2/4] XFS: Return case-insensitive match for dentry cache Barry Naujok
2008-04-21  8:59   ` Christoph Hellwig
2008-04-21  9:46     ` Christoph Hellwig
2008-04-22  3:54       ` Barry Naujok
2008-04-22  4:52         ` Christoph Hellwig
2008-04-21 21:13     ` David Chinner
2008-04-22  4:53       ` Christoph Hellwig
2008-04-22  2:07     ` Barry Naujok
2008-04-22  4:55       ` Christoph Hellwig [this message]
2008-04-21  8:31 ` [PATCH 3/4] XFS: ASCII case-insensitive support Barry Naujok
2008-04-21  9:03   ` Christoph Hellwig
2008-04-21  8:31 ` [PATCH 4/4] XFS: Unicode case-insensitive lookup implementation Barry Naujok
2008-04-21  9:15   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080422045526.GC11321@infradead.org \
    --to=hch@infradead.org \
    --cc=bnaujok@sgi.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).