From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC][PATCH] expose get_block via inode_operations Date: Wed, 23 Apr 2008 03:35:17 -0400 Message-ID: <20080423073517.GA19338@infradead.org> References: <20080422181824.GA2852@unused.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org To: Josef Bacik Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:47715 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbYDWHfS (ORCPT ); Wed, 23 Apr 2008 03:35:18 -0400 Content-Disposition: inline In-Reply-To: <20080422181824.GA2852@unused.rdu.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: No thanks. Just add a generic_fiemap which takes a get_block paramter ala static int ext2_fiemap(struct inode *inode, ...) { return generic_fiemap(inode, ...., ext2_get_block); } To keep the abstractions clear. That's how we do it for all other get_block users already.