linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Al Viro <viro@ZenIV.linux.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [fix] [git pull] VFS patches
Date: Sat, 26 Apr 2008 18:34:14 +0200	[thread overview]
Message-ID: <20080426183414.1acf7ed2@hyperion.delvare> (raw)
In-Reply-To: <20080426042459.GG5882@ZenIV.linux.org.uk>

On Sat, 26 Apr 2008 05:25:00 +0100, Al Viro wrote:
> 	Arrgghhh...
> 
> Sorry about that, I'd been sure I'd folded that one, but it actually got
> lost.  Please apply - that breaks execve().
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 4df3949..a647542 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1788,7 +1788,7 @@ bad_unshare_out:
>  int unshare_files(struct files_struct **displaced)
>  {
>  	struct task_struct *task = current;
> -	struct files_struct *copy;
> +	struct files_struct *copy = NULL;
>  	int error;
>  
>  	error = unshare_fd(CLONE_FILES, &copy);

This apparently prevents the general protection faults I was hitting
with 2.6.25-git8. Linus, please apply Al's fixup patch quickly, as it
will probably hit pretty much everyone trying it.

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2008-04-26 16:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26  2:02 [git pull] VFS patches Al Viro
2008-04-26  4:25 ` [fix] " Al Viro
2008-04-26 16:34   ` Jean Delvare [this message]
2008-04-26 11:01 ` Ingo Molnar
2008-04-26 13:35   ` Matthew Wilcox
2008-04-26 13:44     ` Ingo Molnar
2008-04-26 15:43       ` Ingo Molnar
2008-04-26 19:02     ` Mike Galbraith
2008-05-20 12:04 ` hooanon05

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080426183414.1acf7ed2@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).