From: Jeremy Allison <jra@samba.org>
To: Igor Mammedov <niallain@gmail.com>
Cc: Jeremy Allison <jra@samba.org>, Steve French <smfrench@gmail.com>,
"Q (Igor Mammedov)" <qwerty0987654321@mail.ru>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-cifs-client@lists.samba.org
Subject: Re: dfs path construction fixup for / character in \\server\share component of dfs path
Date: Mon, 28 Apr 2008 11:05:26 -0700 [thread overview]
Message-ID: <20080428180526.GB25413@samba1> (raw)
In-Reply-To: <481478E4.3080100@gmail.com>
On Sun, Apr 27, 2008 at 05:00:20PM +0400, Igor Mammedov wrote:
> Jeremy Allison wrote:
> > On Thu, Apr 24, 2008 at 12:04:06PM +0400, Igor Mammedov wrote:
> >
> >> I'm doing the second call with a short path to get inode info
> >> including server generated inode number. If not for the last
> >> then second call could be omitted and inode be filled with fake
> >> values and locally generated ino.
> >>
> >> PS:
> >> Windows server does not object against the second call and returns
> >> info on the dfs junction point (as directory).
> >> More uniform behavior between different implementations would be
> >> better for all.
> >
> > Can you try this patch against the 3.2 code please. It should
> > cause smbd to return a directory on the short QFILEINFO call.
>
> Thanks for a patch, I've just tested it. Packets dumps are attached.
>
> Short summary:
> 1. unix extentions are disabled. Works.
> * ls on the directory that has a dfs link "dfs2" shows that it is directory
> * second QPATHINFO on "\dfs2" returns that it is directory (pkts 28-29)
>
> 2. unix extentions are enabled. Works partially.
> * ls on the directory that has a dfs link "dfs2" shows that it is a link
> (pkts 26-27). Would be nice if it was listed as directory here.
> * second QPATHINFO on "\dfs2" returns that it is directory (pkts 36-37)
>
> Traverse over DFS junction point now works in both both cases.
Can you send me the same packet trace against Windows please ? I need
to see exactly how Windows responds to the \dfs2 query with flags2
set.
Jeremy.
next prev parent reply other threads:[~2008-04-28 18:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 23:03 dfs path construction fixup for / character in \\server\share component of dfs path Steve French
2008-04-23 14:28 ` Igor Mammedov
2008-04-23 19:11 ` Jeremy Allison
2008-04-23 19:19 ` Jeremy Allison
2008-04-24 8:04 ` Igor Mammedov
2008-04-25 19:22 ` Jeremy Allison
2008-04-25 19:50 ` Jeremy Allison
2008-04-25 21:16 ` Jeremy Allison
2008-04-27 13:00 ` Igor Mammedov
2008-04-28 18:05 ` Jeremy Allison [this message]
2008-04-28 18:51 ` Jeremy Allison
2008-05-21 13:57 ` Igor Mammedov
2008-05-24 0:46 ` Jeremy Allison
2008-05-24 1:33 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428180526.GB25413@samba1 \
--to=jra@samba.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=niallain@gmail.com \
--cc=qwerty0987654321@mail.ru \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).