From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Allison Subject: Re: dfs path construction fixup for / character in \\server\share component of dfs path Date: Mon, 28 Apr 2008 11:05:26 -0700 Message-ID: <20080428180526.GB25413@samba1> References: <524f69650804181603x201f220as14cfd72eaeba5d48@mail.gmail.com> <480F4797.8020100@gmail.com> <20080423191150.GG10791@samba1> <20080423191906.GH10791@samba1> <48103EF6.7010004@gmail.com> <20080425211658.GB21342@samba1> <481478E4.3080100@gmail.com> Reply-To: Jeremy Allison Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeremy Allison , Steve French , "Q (Igor Mammedov)" , linux-fsdevel , linux-cifs-client@lists.samba.org To: Igor Mammedov Return-path: Received: from mail.samba.org ([66.70.73.150]:45488 "EHLO lists.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935739AbYD1SFf (ORCPT ); Mon, 28 Apr 2008 14:05:35 -0400 Content-Disposition: inline In-Reply-To: <481478E4.3080100@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Apr 27, 2008 at 05:00:20PM +0400, Igor Mammedov wrote: > Jeremy Allison wrote: > > On Thu, Apr 24, 2008 at 12:04:06PM +0400, Igor Mammedov wrote: > > > >> I'm doing the second call with a short path to get inode info > >> including server generated inode number. If not for the last > >> then second call could be omitted and inode be filled with fake > >> values and locally generated ino. > >> > >> PS: > >> Windows server does not object against the second call and returns > >> info on the dfs junction point (as directory). > >> More uniform behavior between different implementations would be > >> better for all. > > > > Can you try this patch against the 3.2 code please. It should > > cause smbd to return a directory on the short QFILEINFO call. > > Thanks for a patch, I've just tested it. Packets dumps are attached. > > Short summary: > 1. unix extentions are disabled. Works. > * ls on the directory that has a dfs link "dfs2" shows that it is directory > * second QPATHINFO on "\dfs2" returns that it is directory (pkts 28-29) > > 2. unix extentions are enabled. Works partially. > * ls on the directory that has a dfs link "dfs2" shows that it is a link > (pkts 26-27). Would be nice if it was listed as directory here. > * second QPATHINFO on "\dfs2" returns that it is directory (pkts 36-37) > > Traverse over DFS junction point now works in both both cases. Can you send me the same packet trace against Windows please ? I need to see exactly how Windows responds to the \dfs2 query with flags2 set. Jeremy.