From: Al Viro <viro@ZenIV.linux.org.uk>
To: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] fs: remove local variable copy of f_pos to enable thread-safe updates
Date: Fri, 2 May 2008 10:33:02 +0100 [thread overview]
Message-ID: <20080502093301.GE5882@ZenIV.linux.org.uk> (raw)
In-Reply-To: <91456.70679.qm@web52001.mail.re2.yahoo.com>
On Fri, May 02, 2008 at 02:14:25AM -0700, Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
>
> Remove local variable copy of f_pos to enable thread-safe updates in
> implementation functions of system calls read, readv, write and writev.
... and we are back to square one with racy instances of ->read() that
will use *pos twice, leaving a window for e.g. lseek() to invalidate
e.g. wraparound tests. Not that deciding what to do at the end of
e.g. read() with lseek() happening in the middle would be fun anyway -
esp. since you don't remember the kind of seek it had been.
Go argue that with Linus.
next prev parent reply other threads:[~2008-05-02 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 9:14 [patch] fs: remove local variable copy of f_pos to enable thread-safe updates Matti Linnanvuori
2008-05-02 9:33 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-05-02 15:33 Matti Linnanvuori
2008-05-02 15:41 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502093301.GE5882@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattilinnanvuori@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).