From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [patch] fs: remove local variable copy of f_pos to enable thread-safe updates Date: Fri, 2 May 2008 10:33:02 +0100 Message-ID: <20080502093301.GE5882@ZenIV.linux.org.uk> References: <91456.70679.qm@web52001.mail.re2.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Matti Linnanvuori Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:41097 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756786AbYEBJdE (ORCPT ); Fri, 2 May 2008 05:33:04 -0400 Content-Disposition: inline In-Reply-To: <91456.70679.qm@web52001.mail.re2.yahoo.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 02, 2008 at 02:14:25AM -0700, Matti Linnanvuori wrote: > From: Matti Linnanvuori > > Remove local variable copy of f_pos to enable thread-safe updates in > implementation functions of system calls read, readv, write and writev. ... and we are back to square one with racy instances of ->read() that will use *pos twice, leaving a window for e.g. lseek() to invalidate e.g. wraparound tests. Not that deciding what to do at the end of e.g. read() with lseek() happening in the middle would be fun anyway - esp. since you don't remember the kind of seek it had been. Go argue that with Linus.