From: WANG Cong <xiyou.wangcong@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Eric Youngdale <ericy@cais.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: [Patch] fs/binfmt_elf.c: fix a wrong free
Date: Sat, 3 May 2008 20:46:18 +0800 [thread overview]
Message-ID: <20080503124610.GA3986@hack> (raw)
Fix a wrong free in fs/binfmt_elf.c::elf_core_dump().
Signed-off-by: WANG Cong <wangcong@zeuux.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Eric Youngdale <ericy@cais.com>
---
fs/binfmt_elf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index b25707f..43254e3 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -2032,10 +2032,10 @@ static int elf_core_dump(long signr, struct pt_regs *regs, struct file *file, un
end_coredump:
set_fs(fs);
+ free_note_info(&info);
cleanup:
kfree(elf);
- free_note_info(&info);
return has_dumped;
}
--
1.5.4.1
next reply other threads:[~2008-05-03 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 12:46 WANG Cong [this message]
2008-05-03 13:26 ` [Patch] fs/binfmt_elf.c: fix a wrong free Pekka J Enberg
2008-05-03 14:39 ` WANG Cong
2008-05-04 10:39 ` Pekka Enberg
2008-05-04 14:30 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503124610.GA3986@hack \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@osdl.org \
--cc=ericy@cais.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).