From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 01/15] ecryptfs: clean up (un)lock_parent
Date: Mon, 5 May 2008 06:59:14 -0400
Message-ID: <20080505105914.GA20910@infradead.org>
References: <20080505095440.820370974@szeredi.hu> <20080505095508.218321526@szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: akpm@linux-foundation.org, hch@infradead.org,
	viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Michael Halcrow <mhalcrow@us.ibm.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:32815 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757426AbYEEK7l (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 5 May 2008 06:59:41 -0400
Content-Disposition: inline
In-Reply-To: <20080505095508.218321526@szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, May 05, 2008 at 11:54:42AM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
> 
> dget(dentry->d_parent) --> dget_parent(dentry)
> 
> unlock_parent() is racy and unnecessary.  Replace single caller with
> unlock_dir().
> 
> There are several other suspect uses of ->d_parent in ecryptfs...

Looks good an the first hunk is an obvious fix.  Should probably go into
.26