From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 12/15] vfs: create file_truncate() helper
Date: Mon, 5 May 2008 07:06:46 -0400
Message-ID: <20080505110646.GF20910@infradead.org>
References: <20080505095440.820370974@szeredi.hu> <20080505095526.823086058@szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: akpm@linux-foundation.org, hch@infradead.org,
	viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:52939 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754268AbYEELGt (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 5 May 2008 07:06:49 -0400
Content-Disposition: inline
In-Reply-To: <20080505095526.823086058@szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, May 05, 2008 at 11:54:53AM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
> 
> Clean up do_truncate() API:
> 
>   - create a new function file_truncate()
>   - remove the 'struct file *' argument from do_truncate()

file_truncate looks like a nice little cleanup, but please make sure to
add a kerneldoc comment for every newly added global function.

I don't think there's a point to remove the file argument from
do_truncate and add another helper.