From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: AIM7 40% regression with 2.6.26-rc1 Date: Tue, 6 May 2008 12:44:59 -0400 Message-ID: <20080506164459.GG592@fieldses.org> References: <1210052904.3453.30.camel@ymzhang> <20080506114449.GC32591@elte.hu> <20080506120934.GH19219@parisc-linux.org> <20080506162332.GI19219@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Matthew Wilcox , Ingo Molnar , "Zhang, Yanmin" , LKML , Alexander Viro , Andrew Morton , linux-fsdevel@vger.kernel.org, richterd@citi.umich.edu To: Linus Torvalds Return-path: Received: from mail.fieldses.org ([66.93.2.214]:56304 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755477AbYEFQpV (ORCPT ); Tue, 6 May 2008 12:45:21 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, May 06, 2008 at 09:36:06AM -0700, Linus Torvalds wrote: > > > On Tue, 6 May 2008, Matthew Wilcox wrote: > > > > I've wanted to fix file locks for a while. Here's a first attempt. > > It was done quickly, so I concede that it may well have bugs in it. > > I found (and fixed) one with LTP. > > Hmm. Wouldn't it be nicer to make the lock be a per-inode thing? Or is > there some user that doesn't have the inode info, or does anything that > might cross inode boundaries? The deadlock detection crosses inode boundaries. --b.