From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 6/9] fuse: add export operations
Date: Tue, 13 May 2008 05:01:09 -0400
Message-ID: <20080513090108.GB23849@infradead.org>
References: <20080509124107.645600519@szeredi.hu> <20080509124133.577558326@szeredi.hu> <20080509194030.GA29118@infradead.org> <20080509194642.GA783@infradead.org> <E1Jvpxc-0000Tx-JU@pomaz-ex.szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: hch@infradead.org, akpm@linux-foundation.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:37782 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758922AbYEMJBN (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 13 May 2008 05:01:13 -0400
Content-Disposition: inline
In-Reply-To: <E1Jvpxc-0000Tx-JU@pomaz-ex.szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, May 13, 2008 at 10:34:12AM +0200, Miklos Szeredi wrote:
> One suggestion I have for that patch: leave export_encode_fh() as is
> (or just rename got generic_encode_fh()), and introduce a new
> generic_encode64_fh().  One less magic boolean parameter to worry
> about, and there's very little shared code between those two anyway.

Yeah, probably makes sense to split them.