From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch 04/14] gfs2: dont call permission() Date: Fri, 23 May 2008 05:18:05 -0400 Message-ID: <20080523091805.GB27119@infradead.org> References: <20080521171458.077908538@szeredi.hu> <20080521171546.697638614@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org, Steven Whitehouse To: Miklos Szeredi Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:44961 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753910AbYEWJSF (ORCPT ); Fri, 23 May 2008 05:18:05 -0400 Content-Disposition: inline In-Reply-To: <20080521171546.697638614@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Bad idea. You're duplicating bits out of permission for no good reason. I spent quite a bit of effort to make sure we don't have this duplicated logic around.