From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch 04/14] gfs2: dont call permission() Date: Fri, 23 May 2008 05:32:31 -0400 Message-ID: <20080523093231.GA11963@infradead.org> References: <20080521171458.077908538@szeredi.hu> <20080521171546.697638614@szeredi.hu> <1211533926.3635.552.camel@quoit> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org To: Steven Whitehouse Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:34730 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778AbYEWJce (ORCPT ); Fri, 23 May 2008 05:32:34 -0400 Content-Disposition: inline In-Reply-To: <1211533926.3635.552.camel@quoit> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 23, 2008 at 10:12:06AM +0100, Steven Whitehouse wrote: > > I also suspect the conditional locking in gfs2_do_permission() could > > be cleaned up, due to the removal of the implicit recursion. > > > In order to be sure we'd have to check that there are no NFS code paths > left which can reach this code. That has usually been the reason for > conditional locking. > > In general the patch looks ok to me, and since it doesn't appear to > depend on anything else, I can drop it in my GFS2 git tree if that would > be helpful at this stage, The NFS ->lookup inside filldir recursion is still there, but I plan to fix that for .27. You'll be Cc'ed on that patch.