From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC][PATCH 0/5] Fiemap, an extent mapping ioctl
Date: Wed, 28 May 2008 01:14:28 -0400
Message-ID: <20080528051428.GA24441@infradead.org>
References: <20080525000148.GJ8325@wotan.suse.de> <20080525194203.GB24328@infradead.org> <20080527185622.GR8325@wotan.suse.de> <20080527203124.GC27827@mail.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Mark Fasheh <mfasheh@suse.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org, Andreas Dilger <adilger@shaw.ca>,
	Kalpak Shah <Kalpak.Shah@sun.com>,
	Eric Sandeen <sandeen@redhat.com>,
	Josef Bacik <jbacik@redhat.com>
To: Joel Becker <Joel.Becker@oracle.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:47496 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752388AbYE1FOb (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 28 May 2008 01:14:31 -0400
Content-Disposition: inline
In-Reply-To: <20080527203124.GC27827@mail.oracle.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, May 27, 2008 at 01:31:24PM -0700, Joel Becker wrote:
> 	Provide generic_fiemap_fiecount() that does the operation in
> terms of ->fiemap().  Then filesystems like ocfs2 can just do .fiecount
> = generic_fiemap_fiecount.

Yes, exactly.  Although I suspect for most filesystems an iterator-based
implementation like the one for ext4 in the patchset would actually be
ceaner.

I like these iterators, they helped cleaning up a lot of messy interface
in XFS.