From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/5] vfs: vfs-level fiemap interface
Date: Thu, 29 May 2008 09:04:37 -0400
Message-ID: <20080529130437.GD21299@infradead.org>
References: <20080525000157.GK8325@wotan.suse.de> <20080528194215.GI7263@webber.adilger.int> <20080529012435.GC12405@disturbed>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: Andreas Dilger <adilger@sun.com>, Mark Fasheh <mfasheh@suse.com>,
	linux-fsdevel@vger.kernel.org, Josef Bacik <jbacik@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:57383 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756727AbYE2NEi (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 29 May 2008 09:04:38 -0400
Content-Disposition: inline
In-Reply-To: <20080529012435.GC12405@disturbed>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, May 29, 2008 at 11:24:35AM +1000, Dave Chinner wrote:
> To fix this, FIECOUNT becomes much more complex however other
> existing interfaces will still expose conflicting information (e.g.
> XFS_IOC_FSGETXATTR). Hence I don't think extent merging is a
> good idea in general for this API. For specific implementations
> it could be considered (e.g. the block-based filesystem wrappers)
> but it should not forced on all implementations.

Yes.  Extent merging only really makes sense for block based
filesystems, and there should be an output flag telling the user that
this happened.