From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Dilger Subject: Re: [PATCH 1/5] vfs: vfs-level fiemap interface Date: Thu, 29 May 2008 11:02:16 -0600 Message-ID: <20080529170216.GD2985@webber.adilger.int> References: <20080525000157.GK8325@wotan.suse.de> <20080528194215.GI7263@webber.adilger.int> <20080529012435.GC12405@disturbed> <20080529130437.GD21299@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Cc: Mark Fasheh , linux-fsdevel@vger.kernel.org, Josef Bacik To: Christoph Hellwig Return-path: Received: from sca-es-mail-1.Sun.COM ([192.18.43.132]:65001 "EHLO sca-es-mail-1.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbYE2RCY (ORCPT ); Thu, 29 May 2008 13:02:24 -0400 Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m4TH2IJJ028671 for ; Thu, 29 May 2008 10:02:19 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0K1N00K0134U2G00@fe-sfbay-09.sun.com> (original mail from adilger@sun.com) for linux-fsdevel@vger.kernel.org; Thu, 29 May 2008 10:02:18 -0700 (PDT) In-reply-to: <20080529130437.GD21299@infradead.org> Content-disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On May 29, 2008 09:04 -0400, Christoph Hellwig wrote: > On Thu, May 29, 2008 at 11:24:35AM +1000, Dave Chinner wrote: > > To fix this, FIECOUNT becomes much more complex however other > > existing interfaces will still expose conflicting information (e.g. > > XFS_IOC_FSGETXATTR). Hence I don't think extent merging is a > > good idea in general for this API. For specific implementations > > it could be considered (e.g. the block-based filesystem wrappers) > > but it should not forced on all implementations. > > Yes. Extent merging only really makes sense for block based > filesystems, and there should be an output flag telling the user > that this happened. I've accepted that extent merging is a bad idea for the generic interface. I think for block-mapped filesystems this pretty much has to happen. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.