From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Dilger <adilger@sun.com>
Subject: Re: [PATCH 1/5] vfs: vfs-level fiemap interface
Date: Fri, 30 May 2008 11:24:08 -0600
Message-ID: <20080530172408.GE5013@webber.adilger.int>
References: <20080525000157.GK8325@wotan.suse.de>
 <20080525072816.GH3516@webber.adilger.int>
 <20080527183117.GP8325@wotan.suse.de>
 <20080528160952.GH7263@webber.adilger.int>
 <20080528172434.GB6031@mail.oracle.com>
 <20080529234648.GN2985@webber.adilger.int>
 <20080530001526.GR8325@wotan.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7BIT
Cc: Joel Becker <Joel.Becker@oracle.com>, linux-fsdevel@vger.kernel.org
To: Mark Fasheh <mfasheh@suse.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from sca-es-mail-2.Sun.COM ([192.18.43.133]:50497 "EHLO
	sca-es-mail-2.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752314AbYE3RYX (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 30 May 2008 13:24:23 -0400
Received: from fe-sfbay-10.sun.com ([192.18.43.129])
	by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m4UHOMUS019320
	for <linux-fsdevel@vger.kernel.org>; Fri, 30 May 2008 10:24:22 -0700 (PDT)
Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K1O00M01YI2SN00@fe-sfbay-10.sun.com> (original mail from adilger@sun.com)
 for linux-fsdevel@vger.kernel.org; Fri, 30 May 2008 10:24:22 -0700 (PDT)
In-reply-to: <20080530001526.GR8325@wotan.suse.de>
Content-disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On May 29, 2008  17:15 -0700, Mark Fasheh wrote:
> calls. It would take as arguments, the fiemap_extent_info struct and set of
> flags which the fs supports. That would allow backported modules to plug in
> their own check, but we retain the niceness of having the checks in a
> central place for in-tree file systems.
> 
> int fiemap_check_flags(struct fiemap_extent_info fieinfo, u32 fs_flags)
> {
> 	u32 incompat_flags;
> 
> 	incompat_flags = fieinfo.fi_flags & ~(FIEMAP_FLAGS_COMPAT & fs_flags);
> 	if (incompat_flags) {
> 		fieinfo->fi_flags = incompat_flags;
> 		return -EBADR;
> 	}
> 	return 0;
> }

I'm OK with this approach.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.