From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
hch@lst.de, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
Artem.Bityutskiy@nokia.com
Subject: Re: [PATCH] always set a/c/mtime through ->setattr
Date: Sat, 31 May 2008 09:24:45 -0400 [thread overview]
Message-ID: <20080531132444.GA22936@infradead.org> (raw)
In-Reply-To: <20080531132048.GA4201@ZenIV.linux.org.uk>
On Sat, May 31, 2008 at 02:20:48PM +0100, Al Viro wrote:
> And there's one more problem, promising very ugly code review: locking
> rules for notify_change() had suddenly changed - you are calling it
> without i_mutex now. And ext3_setattr() is not happy - especially due
> to this blind call of ext3_orphan_del() in there. We can easily fix
> that one, but you'll need to audit the rest of instances...
Yeah, I've actually started an audit of the setattr instance and there's
even more crap turning up. I'm working on a bigger series to sort these
things out.
next prev parent reply other threads:[~2008-05-31 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 6:08 [PATCH] always set a/c/mtime through ->setattr Christoph Hellwig
2008-05-20 6:19 ` Artem Bityutskiy
2008-05-20 6:28 ` Christoph Hellwig
2008-05-20 7:40 ` Miklos Szeredi
2008-05-20 8:33 ` Christoph Hellwig
2008-05-22 18:10 ` Miklos Szeredi
2008-05-31 13:20 ` Al Viro
2008-05-31 13:24 ` Christoph Hellwig [this message]
2008-05-31 13:35 ` Al Viro
2008-05-21 6:58 ` [PATCH 2/2] " Christoph Hellwig
2008-05-21 17:19 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080531132444.GA22936@infradead.org \
--to=hch@infradead.org \
--cc=Artem.Bityutskiy@nokia.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).