From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] always set a/c/mtime through ->setattr Date: Sat, 31 May 2008 09:24:45 -0400 Message-ID: <20080531132444.GA22936@infradead.org> References: <20080520060838.GA6436@lst.de> <20080520083351.GA14826@lst.de> <20080531132048.GA4201@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Miklos Szeredi , hch@lst.de, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, Artem.Bityutskiy@nokia.com To: Al Viro Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:51711 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbYEaNYu (ORCPT ); Sat, 31 May 2008 09:24:50 -0400 Content-Disposition: inline In-Reply-To: <20080531132048.GA4201@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, May 31, 2008 at 02:20:48PM +0100, Al Viro wrote: > And there's one more problem, promising very ugly code review: locking > rules for notify_change() had suddenly changed - you are calling it > without i_mutex now. And ext3_setattr() is not happy - especially due > to this blind call of ext3_orphan_del() in there. We can easily fix > that one, but you'll need to audit the rest of instances... Yeah, I've actually started an audit of the setattr instance and there's even more crap turning up. I'm working on a bigger series to sort these things out.