Re: [RFC 3/7] cramfs: allow unlinking of files

Jörn Engel
2008-06-01T16:54:47Z

On Sat, 31 May 2008 17:20:16 +0200, arnd@arndb.de wrote:
>
> +int cramfs_unlink(struct inode *dir, struct dentry *dentry)
> +{
> + struct inode *inode = dentry->d_inode;
> + struct dentry *new;
> +
> + inode->i_ctime = dir->i_ctime = dir->i_mtime = CURRENT_TIME;
> + drop_nlink(inode);
> + new = d_alloc(dentry->d_parent, &dentry->d_name);
> + d_add(new, NULL);
> +
> + dget(dentry);

How is the negative dentry dropped on umount? Looks like we want a
per-sb list to put them on. Then we can walk it and dput each one at
umount time.

> + return 0;
> +}

Jörn

--
"[One] doesn't need to know [...] how to cause a headache in order
to take an aspirin."
-- Scott Culp, Manager of the Microsoft Security Response Center, 2001
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html