From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [RFC 3/7] cramfs: allow unlinking of files Date: Sun, 1 Jun 2008 18:54:40 +0200 Message-ID: <20080601165439.GD13094@logfs.org> References: <20080531152013.031903990@arndb.de> <20080531153510.820446949@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de To: arnd@arndb.de Return-path: Received: from lazybastard.de ([212.112.238.170]:56049 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbYFAQyr (ORCPT ); Sun, 1 Jun 2008 12:54:47 -0400 Content-Disposition: inline In-Reply-To: <20080531153510.820446949@arndb.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, 31 May 2008 17:20:16 +0200, arnd@arndb.de wrote: > =20 > +int cramfs_unlink(struct inode *dir, struct dentry *dentry) > +{ > + struct inode *inode =3D dentry->d_inode; > + struct dentry *new; > + > + inode->i_ctime =3D dir->i_ctime =3D dir->i_mtime =3D CURRENT_TIME; > + drop_nlink(inode); > + new =3D d_alloc(dentry->d_parent, &dentry->d_name); > + d_add(new, NULL); > + > + dget(dentry); How is the negative dentry dropped on umount? Looks like we want a per-sb list to put them on. Then we can walk it and dput each one at umount time. > + return 0; > +} J=C3=B6rn --=20 "[One] doesn't need to know [...] how to cause a headache in order to take an aspirin." -- Scott Culp, Manager of the Microsoft Security Response Center, 2001 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html