From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC 2/7] cramfs: create unique inode numbers Date: Sun, 1 Jun 2008 23:24:51 +0200 Message-ID: <200806012324.51734.arnd@arndb.de> References: <20080531152013.031903990@arndb.de> <20080531153510.692084580@arndb.de> <20080601165048.GC13094@logfs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de To: =?utf-8?q?J=C3=B6rn_Engel?= Return-path: Received: from moutng.kundenserver.de ([212.227.126.174]:53127 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbYFAVZE convert rfc822-to-8bit (ORCPT ); Sun, 1 Jun 2008 17:25:04 -0400 In-Reply-To: <20080601165048.GC13094@logfs.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sunday 01 June 2008, J=C3=B6rn Engel wrote: > On Sat, 31 May 2008 17:20:15 +0200, arnd@arndb.de wrote: > >=20 > > This changes the inode number in cramfs to be based on > > the location of the dentry instead of the file, in order > > to make inodes unique. >=20 > Couldn't this cause problems for NFS? The same inode no longer has a > stable inode number across reboots. Basing on dentry location can al= so > be an information leak and cause problems on 64bit machines with old > userspace. Sorry if I was not clear with this: I meant dentry location on disk, not in memory. So the inode number is still stable across reboots and does not leak data, it is just different from before. > We could keep the original approach and use a static counter otherwis= e. > Something roughly like this: One thing I like about my 2/7 patch is that it actually reduces the amo= unt of code in the file system, while your solution would increase it, with otherwise identical behaviour. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html