From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: mtk.manpages@googlemail.com, drepper@redhat.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-man@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] utimensat() non-conformances and fixes [v3]
Date: Tue, 3 Jun 2008 12:22:21 +0100 [thread overview]
Message-ID: <20080603112221.GW28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1K3URo-0005sj-JW@pomaz-ex.szeredi.hu>
On Tue, Jun 03, 2008 at 01:13:00PM +0200, Miklos Szeredi wrote:
> > > I'm not sure of the correct way to get the required nameidata (to do a
> > > vfs_permission() call) from the file descriptor. Can you give me a
> > > tip there?
> >
> > Could you point me at the right way of doing this?
>
> You don't need nameidata for this at all. Just call permission() with
> a NULL nameidata.
>
> Ugly API? Yes, will be cleaned up if we manage to find some common
> ground with the VFS maintainers.
As soon as I'm done with sysctls...
FWIW, I very much doubt that you are right wrt required permissions, though.
AFAICS, intent here is "if you can write to file, you can touch the timestamps
anyway" and having descriptor opened for write gives that, current permissions
be damned.
next prev parent reply other threads:[~2008-06-03 11:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 8:31 [PATCH] utimensat() non-conformances and fixes -- version 2 Michael Kerrisk
[not found] ` <482D4665.4050401-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-05-16 8:34 ` Michael Kerrisk
2008-05-16 16:59 ` Miklos Szeredi
[not found] ` <E1Jx3Gw-0002eA-55-8f8m9JG5TPIdUIPVzhDTVZP2KDSNp7ea@public.gmane.org>
2008-05-17 19:57 ` Michael Kerrisk
2008-05-19 9:50 ` Miklos Szeredi
2008-05-19 10:12 ` Miklos Szeredi
2008-05-19 12:24 ` Michael Kerrisk
2008-05-19 13:17 ` Miklos Szeredi
2008-05-30 15:34 ` [PATCH] utimensat() non-conformances and fixes [v3] Michael Kerrisk
[not found] ` <48401E7E.9090304-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-05-30 16:37 ` Miklos Szeredi
2008-05-30 18:24 ` Michael Kerrisk
2008-05-30 19:22 ` Miklos Szeredi
[not found] ` <E1K2ABK-0002ck-UT-8f8m9JG5TPIdUIPVzhDTVZP2KDSNp7ea@public.gmane.org>
2008-05-30 19:32 ` Matthew Wilcox
[not found] ` <20080530193207.GB28074-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
2008-05-30 20:08 ` Miklos Szeredi
[not found] ` <cfd18e0f0805301124o5f217dden10726b268d05d81a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-05-30 19:43 ` Michael Kerrisk
[not found] ` <cfd18e0f0805301243h7d862963o8320a2c1f48942ce-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-05-30 20:17 ` Miklos Szeredi
[not found] ` <E1K2B2k-0002kS-Cz-8f8m9JG5TPIdUIPVzhDTVZP2KDSNp7ea@public.gmane.org>
2008-05-31 5:28 ` Michael Kerrisk
2008-05-30 20:17 ` Andrew Morton
2008-05-31 5:44 ` Michael Kerrisk
2008-06-03 11:05 ` Michael Kerrisk
[not found] ` <cfd18e0f0806030405u1c32b114pa0fdd979f36f87fb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-03 11:13 ` Miklos Szeredi
2008-06-03 11:22 ` Al Viro [this message]
2008-06-03 11:27 ` Michael Kerrisk
2008-06-03 11:30 ` Jamie Lokier
[not found] ` <20080603113018.GA27955-yetKDKU6eevNLxjTenLetw@public.gmane.org>
2008-06-03 11:39 ` Michael Kerrisk
2008-06-03 11:49 ` Al Viro
[not found] ` <20080603114921.GX28946-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2008-06-03 11:58 ` Al Viro
2008-06-03 12:01 ` Jamie Lokier
[not found] ` <20080603120135.GA28905-yetKDKU6eevNLxjTenLetw@public.gmane.org>
2008-06-03 12:08 ` Al Viro
[not found] ` <20080603120850.GZ28946-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2008-06-03 12:10 ` Jamie Lokier
[not found] ` <20080603112221.GW28946-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2008-06-03 12:16 ` Miklos Szeredi
2008-06-03 13:05 ` Al Viro
2008-06-03 11:52 ` Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603112221.GW28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=drepper@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mtk.manpages@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).