From: Jamie Lokier <jamie@shareable.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1 of 3] block: Export I/O hints for block devices and partitions
Date: Fri, 6 Jun 2008 15:21:03 +0100 [thread overview]
Message-ID: <20080606142103.GA22158@shareable.org> (raw)
In-Reply-To: <3e5d8520d247223a236e.1212643370@sermon.lab.mkp.net>
Martin K. Petersen wrote:
> + sector_t phys_offset;
> + unsigned int optimal_io_block;
> + unsigned int optimal_io_length;
Wouldn't off_t or sector_t be more appropriate?
I can (vaguely) imagine devices with stripe sizes >= 2GiB in the not
too distant future. Especially clusters with high speed interconnect
and RAM-backed devices.
There's no harm in an application doing smaller I/O. It should always
choose appropriate values itself anyway.
But it seems cleaner to report the numbers derived from actual drive
topology.
-- Jamie
next prev parent reply other threads:[~2008-06-06 14:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 5:22 [PATCH 0 of 3] [RFC] I/O Hints Martin K. Petersen
2008-06-05 5:22 ` [PATCH 1 of 3] block: Export I/O hints for block devices and partitions Martin K. Petersen
2008-06-05 14:42 ` James Bottomley
2008-06-06 1:18 ` Martin K. Petersen
2008-06-06 14:21 ` Jamie Lokier [this message]
2008-06-05 5:22 ` [PATCH 2 of 3] md: Export preferred I/O sizes and physical alignment Martin K. Petersen
2008-06-05 5:22 ` [PATCH 3 of 3] sd: Export preferred I/O sizes Martin K. Petersen
2008-06-05 11:25 ` Boaz Harrosh
2008-06-05 6:27 ` [PATCH 0 of 3] [RFC] I/O Hints Andreas Dilger
2008-06-05 10:32 ` Jamie Lokier
2008-06-05 12:35 ` Matthew Wilcox
2008-06-05 17:02 ` Dan Williams
2008-06-06 1:03 ` Martin K. Petersen
2008-06-06 14:02 ` Jamie Lokier
2008-06-06 16:48 ` Martin K. Petersen
2008-06-09 10:47 ` Jamie Lokier
2008-06-10 2:17 ` Martin K. Petersen
2008-06-05 10:40 ` Jamie Lokier
2008-06-05 19:19 ` Andreas Dilger
2008-06-06 12:55 ` Jamie Lokier
2008-06-06 1:16 ` Martin K. Petersen
2008-06-06 4:51 ` Dave Chinner
2008-06-06 16:53 ` Martin K. Petersen
2008-06-07 20:54 ` Dave Chinner
2008-06-09 15:05 ` Martin K. Petersen
2008-06-06 12:52 ` Jamie Lokier
2008-06-06 14:26 ` Jamie Lokier
2008-06-06 16:56 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080606142103.GA22158@shareable.org \
--to=jamie@shareable.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).