linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	autofs mailing list <autofs@linux.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: [PATCH] autofs4 - detect invalid direct mount requests
Date: Fri, 20 Jun 2008 13:13:03 +0800	[thread overview]
Message-ID: <20080620051301.9988.94307.stgit@raven.themaw.net> (raw)

autofs v5 dierct and offset mounts within an autofs filesystem are
triggered by existing autofs triger mounts so the mount point dentry
must be positive. If the mount point dentry is negative then the
trigger doesn't exist so we can return fail immediately.

Signed-off-by: Ian Kent <raven@themaw.net>

---

 fs/autofs4/waitq.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index cd21fd4..ae637d9 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -307,6 +307,10 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry,
 	if (sbi->catatonic)
 		return -ENOENT;
 
+	if (!dentry->d_inode &&
+	    (sbi->type & (AUTOFS_TYPE_DIRECT | AUTOFS_TYPE_OFFSET)))
+		return -ENOENT;
+
 	name = kmalloc(NAME_MAX + 1, GFP_KERNEL);
 	if (!name)
 		return -ENOMEM;

             reply	other threads:[~2008-06-20  5:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20  5:13 Ian Kent [this message]
2008-06-20 13:00 ` [PATCH] autofs4 - detect invalid direct mount requests Jeff Moyer
2008-06-20 13:12   ` Ian Kent
2008-07-02 13:46   ` Ian Kent
2008-07-01 21:17 ` Andrew Morton
2008-07-02  8:59   ` Ian Kent
2008-07-02 13:42     ` Jeff Moyer
2008-07-02 13:50       ` Ian Kent
2008-07-02 16:54         ` Andrew Morton
2008-07-03  1:57           ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080620051301.9988.94307.stgit@raven.themaw.net \
    --to=raven@themaw.net \
    --cc=akpm@linux-foundation.org \
    --cc=autofs@linux.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).